lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 025/281] qed: Correct doorbell configuration for !4Kb pages
    Date
    From: Ram Amrani <Ram.Amrani@cavium.com>

    [ Upstream commit a82dadbce47395747824971db08a128130786fdc ]

    When configuring the doorbell DPI address, driver aligns the start
    address to 4KB [HW-pages] instead of host PAGE_SIZE.
    As a result, RoCE applications might receive addresses which are
    unaligned to pages [when PAGE_SIZE > 4KB], which is a security risk.

    Fixes: 51ff17251c9c ("qed: Add support for RoCE hw init")
    Signed-off-by: Ram Amrani <Ram.Amrani@cavium.com>
    Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/net/ethernet/qlogic/qed/qed_dev.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
    index 9a6adbd9ed34..d02313770fc2 100644
    --- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
    +++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
    @@ -850,7 +850,7 @@ qed_hw_init_pf_doorbell_bar(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt)
    NULL) +
    qed_cxt_get_proto_cid_count(p_hwfn, PROTOCOLID_ETH,
    NULL);
    - norm_regsize = roundup(QED_PF_DEMS_SIZE * non_pwm_conn, 4096);
    + norm_regsize = roundup(QED_PF_DEMS_SIZE * non_pwm_conn, PAGE_SIZE);
    min_addr_reg1 = norm_regsize / 4096;
    pwm_regsize = db_bar_size - norm_regsize;

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-19 22:44    [W:4.029 / U:0.880 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site