Messages in this thread | | | From | Alexander Duyck <> | Date | Fri, 16 Mar 2018 09:30:24 -0700 | Subject | Re: [Intel-wired-lan] [PATCH v3 09/18] fm10k: Eliminate duplicate barriers on weakly-ordered archs |
| |
On Fri, Mar 16, 2018 at 9:16 AM, Sinan Kaya <okaya@codeaurora.org> wrote: > Code includes wmb() followed by writel(). writel() already has a > barrier on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing > the register write. > > Since code already has an explicit barrier call, changing writel() to > writel_relaxed(). > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
You can update the writel call in fm10k_tx_map as well.
Of the drivers updated in drivers/net/ethernet/intel/* it looks like this is the only one that still requires any additional changes.
Thanks.
- Alex
| |