lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/9] x86/dumpstack: Save first regs set for the executive summary
On Fri, Mar 16, 2018 at 01:11:17PM +0100, Borislav Petkov wrote:
> On Fri, Mar 16, 2018 at 07:01:12AM -0500, Josh Poimboeuf wrote:
> > Hm, the "Code: Bad RIP value" will always be shown for syscall regs,
> > which will probably cause some unnecessary confusion/worry. Should we
> > just skip printing it for the "regs->ip < PAGE_OFFSET" case?
>
> How about we remove that check altogether?
>
> I mean, __copy_from_user_inatomic() by way of probe_kernel_read() should
> be able to handle every address.
>
> And if it doesn't, it says so:
>
> if (probe_kernel_read(opcodes, ip, OPCODE_BUFSIZE)) {
> pr_cont("Bad RIP value.\n");
>
>
> And if we *can* print opcode bytes, why not do so? It is one more hint
> when debugging, who knows, might prove useful...
>
> Hmm?

Yeah, sounds good to me. I think an earlier version of your patches
already printed the user space opcodes anyway.

--
Josh

\
 
 \ /
  Last update: 2018-03-16 14:16    [W:0.054 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site