lkml.org 
[lkml]   [2018]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 15/63] MIPS: OCTEON: irq: Check for null return on kzalloc allocation
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit 902f4d067a50ccf645a58dd5fb1d113b6e0f9b5b upstream.

    The allocation of host_data is not null checked, leading to a null
    pointer dereference if the allocation fails. Fix this by adding a null
    check and return with -ENOMEM.

    Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Acked-by: David Daney <david.daney@cavium.com>
    Cc: Ralf Baechle <ralf@linux-mips.org>
    Cc: "Steven J. Hill" <Steven.Hill@cavium.com>
    Cc: linux-mips@linux-mips.org
    Cc: <stable@vger.kernel.org> # 4.0+
    Patchwork: https://patchwork.linux-mips.org/patch/18658/
    Signed-off-by: James Hogan <jhogan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/mips/cavium-octeon/octeon-irq.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/arch/mips/cavium-octeon/octeon-irq.c
    +++ b/arch/mips/cavium-octeon/octeon-irq.c
    @@ -2246,6 +2246,8 @@ static int __init octeon_irq_init_cib(st
    }

    host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);
    + if (!host_data)
    + return -ENOMEM;
    raw_spin_lock_init(&host_data->lock);

    addr = of_get_address(ciu_node, 0, NULL, NULL);

    \
     
     \ /
      Last update: 2018-03-16 18:28    [W:4.127 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site