Messages in this thread | | | From | Dexuan Cui <> | Subject | RE: [PATCH v4 1/2] PCI: hv: Serialize the present and eject work items | Date | Thu, 15 Mar 2018 17:55:03 +0000 |
| |
> From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Sent: Thursday, March 15, 2018 10:02 > On Thu, Mar 15, 2018 at 02:20:53PM +0000, Dexuan Cui wrote: > > When we hot-remove the device, we first receive a PCI_EJECT message and > > then receive a PCI_BUS_RELATIONS message with bus_rel->device_count == > 0. > > > > The first message is offloaded to (), and the second > > is offloaded to pci_devices_present_work(). Both the paths can be running > > list_del(&hpdev->list_entry), causing general protection fault, because > > system_wq can run them concurrently. > > > > The patch eliminates the race condition. > > > > Cc: stable@vger.kernel.org > > I need to know either what commit you are fixing (ie Fixes: tag - which > is preferrable) or you tell me which kernel versions we are targeting > for the stable backport. > > Thanks, > Lorenzo
Sorry. Here I was hesitant to add a "Fixes:" because the bug was there the first day when the driver was introduced.
Please use Fixes: 4daace0d8ce8 ("PCI: hv: Add paravirtual PCI front-end for Microsoft Hyper-V VMs") or Cc: <stable@vger.kernel.org> # v4.6+
Thanks, -- Dexuan
| |