Messages in this thread | | | Date | Thu, 15 Mar 2018 17:31:25 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 6/9] x86/microcode/AMD: verify patch section type for every such section |
| |
On Tue, Mar 13, 2018 at 10:07:01PM +0100, Maciej S. Szmigiero wrote: > We should check whether the patch section currently being processed is > actually a patch section for each of them (not just the first one) in the > late loader verify_and_add_patch() function, just like the early loader > already does in parse_container() function. > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> > --- > arch/x86/kernel/cpu/microcode/amd.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c > index 0f78200f2f6c..3ad23e72c2b0 100644 > --- a/arch/x86/kernel/cpu/microcode/amd.c > +++ b/arch/x86/kernel/cpu/microcode/amd.c > @@ -627,6 +627,11 @@ static int verify_and_add_patch(u8 family, u8 *fw, size_t leftover) > if (leftover < SECTION_HDR_SIZE + sizeof(*mc_hdr)) > return leftover; > > + if (*(u32 *)fw != UCODE_UCODE_TYPE) {
Store that in a local var patch_type for better readability, while you're touching that.
Also, for all your patch subject names for your next submission, start the patch subject sentence with a capital letter:
Subject: [PATCH v3 6/9] x86/microcode/AMD: Verify patch section type for every such section
Thx.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |