lkml.org 
[lkml]   [2018]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH RFC] xfs, memcg: Call xfs_fs_nr_cached_objects() only in case of global reclaim
    From
    Date
    xfs_reclaim_inodes_count(XFS_M(sb)) does not care about memcg.
    So, it's called for memcg reclaim too, e.g. this list is shrinked
    disproportionality to another lists.

    This looks confusing, so I'm reporting about this.
    Consider this patch as RFC.

    Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
    ---
    fs/xfs/xfs_super.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
    index 951271f57d00..124568aefa94 100644
    --- a/fs/xfs/xfs_super.c
    +++ b/fs/xfs/xfs_super.c
    @@ -1788,6 +1788,8 @@ xfs_fs_nr_cached_objects(
    struct super_block *sb,
    struct shrink_control *sc)
    {
    + if (sc->memcg)
    + return 0;
    return xfs_reclaim_inodes_count(XFS_M(sb));
    }

    \
     
     \ /
      Last update: 2018-03-15 16:02    [W:2.325 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site