Messages in this thread | | | Subject | Re: [PATCH] can: enable multi-queue for SocketCAN devices | From | Marc Kleine-Budde <> | Date | Wed, 14 Mar 2018 23:17:32 +0100 |
| |
On 03/14/2018 05:51 PM, Jonas Mark (BT-FIR/ENG1) wrote: >> That doesn't matter. It would be the first driver that makes use of the >> feature, so we can learn from it. And you might get a free review of >> your driver. > > Of course we would be happy if somebody was volunteering to review > our driver for free.
If my time permits, I'll throw some eyeballs on the driver.
> The driver consists of two layers because the HW is accessed via SPI.
Normal SPI?
> So there is a SPI driver of 1000 lines. On top of that is the CAN > driver and it has 600 lines. Because the HW does more than just > CAN there is another driver which implements a char device with > additional 300 lines. > > Are there still volunteers?
The SPI and the CAN driver would be the most interesting ones.
>>> Our motivation to separate this patch from the proprietary SocketCAN >>> driver >> >> Looking at your email address I assume your employer sells devices with >> this hardware and the driver. So someone has to provide the sources for >> it anyways to fulfil the GPL license requirements. :) > > I will have to check but I am pretty confident that we would be willing > to publish the driver on these mailing lists as well. We will anyhow > ship the source code (or a written offer) with every distribution.
Sure - can I find your devices used and low priced on ebay :) ?
> If you are really serious about the review I will get the process > rolling for an early publication of our driver.
Yes, please go ahead!
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[unhandled content-type:application/pgp-signature] | |