Messages in this thread | | | From | Richard Weinberger <> | Subject | Re: [PATCH 2/2] mtd: ubi: use put_device() if device_register fail | Date | Wed, 14 Mar 2018 20:25:25 +0100 |
| |
Am Mittwoch, 14. März 2018, 19:56:52 CET schrieb Boris Brezillon: > On Fri, 9 Mar 2018 16:20:49 +0530 > > Arvind Yadav <arvind.yadav.cs@gmail.com> wrote: > > if device_register() returned an error! Always use put_device() > > to give up the reference initialized. > > > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > > --- > > > > drivers/mtd/ubi/vmt.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c > > index 3fd8d7f..db85b68 100644 > > --- a/drivers/mtd/ubi/vmt.c > > +++ b/drivers/mtd/ubi/vmt.c > > @@ -609,6 +609,7 @@ int ubi_add_volume(struct ubi_device *ubi, struct > > ubi_volume *vol)> > > return err; > > > > out_cdev: > > + put_device(&vol->dev); > > > > cdev_del(&vol->cdev); > > use-after-free bug here: put_device() has freed the vol obj, and you're > dereferencing the pointer just after that.
eeek, thanks for looking at more context. Arvind, while you are right that put_device() is missing, please double check that freeing the devices is also correct.
Thanks, //richard
| |