Messages in this thread | | | Subject | Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices | From | Jakob Unterwurzacher <> | Date | Wed, 14 Mar 2018 10:14:25 +0100 |
| |
On 14.03.18 10:11, Wolfgang Grandegger wrote: >> + /* handle error frames */ >> + canid = le32_to_cpu(m->msg.can_msg.id); >> + if (canid & CAN_ERR_FLAG) { >> + ucan_handle_error_frame(up, m, canid); >> + /* drop frame if berr-reporting is off */ >> + if (!(up->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING)) >> + return; >> + } > > You still do not generate error messages for state changes, IIUC.
The hardware generates error frames on state changes - is that what you mean?
In our testing, the state shows up (and updates) correctly in
ip -details -statistics link show can0
Best regards, Jakob
| |