lkml.org 
[lkml]   [2018]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] dma-mapping: move dma configuration to bus infrastructure
    > Agree. There is no good point in duplicating the code.
    > So this new API will be part of 'drivers/base/dma-mapping.c' file?

    Yes.

    > > As mention in my previous reply I think we don't even need a deconfigure
    > > callback at this point - just remove the ACPI and OF wrappers and
    > > clear the dma ops.
    > >
    > > Also in this series we should replace the force_dma flag by use of the
    > > proper method, e.g. give a force parameter to of_dma_configure and the
    > > new dma_common_configure helper that the busses that want it can set.
    >
    > I am more inclined to what Robin states in other mail to keep symmetry.
    > i.e. to keep dma_configure() and dma_deconfigure() and call
    > dev->bus->dma_configure from dma_configure(). Is this okay?

    Sure.

    \
     
     \ /
      Last update: 2018-03-14 10:03    [W:3.768 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site