Messages in this thread | | | Subject | Re: [PATCH 1/2, pci] pci: Addition of PCI_DEV_FLAGS_QUIET_PCI_REALIGN attribute to the PCI subsystem | From | Desnes Augusto Nunes do Rosário <> | Date | Wed, 14 Mar 2018 18:12:23 -0300 |
| |
On 03/14/2018 03:55 PM, Bjorn Helgaas wrote:
>>> As far as I'm concerned, we can just remove these messages completely. >>> I don't think there's any real value there. >> >> After I found out that this was happening to all PCI devices on powerpc due >> to the __weak >> pcibios_default_alignment() interface (necessary for VFIO passthrough and >> performance), I confess that this was my first approach to this matter; >> however I couldn't vouch the need of these messages on other architectures. >> >> If there are no further concerns, I definitely prefer sending a second >> version of this patch only eliminating these messages and attesting the >> reason why. >> >> Thank you very much for your review Bjorn, > > No problem, welcome to PCI, and I hope we see more of your work!
Bjorn,
Awesome! A second version of this fix has been sent with a new title: "[PATCH, pci, v2] pci: Delete PCI disabling informational messages"
Thanks for the review and warm welcome!
-- Desnes A. Nunes do Rosário --------------------------
| |