lkml.org 
[lkml]   [2018]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 18/31] perf vendor events arm64: Add armv8-recommended.json
    From
    Date
    On 13/03/2018 15:08, Ingo Molnar wrote:
    >
    > * John Garry <john.garry@huawei.com> wrote:
    >
    >> On 13/03/2018 14:26, Ingo Molnar wrote:
    >>>
    >>> * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
    >>>
    >>>> From: John Garry <john.garry@huawei.com>
    >>>>
    >>>> Add JSON for ARMv8 IMPLEMENTATION DEFINED recommended events.
    >>>>
    >>>> The JSON is copied from ARMv8 architecture reference manual, available
    >>>> here:
    >>>>
    >>>> https://static.docs.arm.com/ddi0487/ca/DDI0487C_a_armv8_arm.pdf
    >>>>
    >>>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>

    Originally-from: Shaokun Zhang <zhangshaokun@hisilicon.com>

    >>>> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    >>>> Cc: Andi Kleen <ak@linux.intel.com>
    >>>> Cc: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
    >>>> Cc: Jiri Olsa <jolsa@redhat.com>
    >>>> Cc: Namhyung Kim <namhyung@kernel.org>
    >>>> Cc: Peter Zijlstra <peterz@infradead.org>
    >>>> Cc: Shaokun Zhang <zhangshaokun@hisilicon.com>
    >>>> Cc: Will Deacon <will.deacon@arm.com>
    >>>> Cc: William Cohen <wcohen@redhat.com>
    >>>> Cc: linux-arm-kernel@lists.infradead.org
    >>>> Cc: linuxarm@huawei.com
    >>>> Link: http://lkml.kernel.org/r/1520506716-197429-9-git-send-email-john.garry@huawei.com
    >>>> Signed-off-by: John Garry <john.garry@huawei.com>
    >>>> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    >>>
    >>> That's not a valid SOB chain, author != first-Signed-off-by.
    >>>
    >>
    >> Right, so my SOB can go first.
    >>
    >> Let me know how to help remedy.
    >
    > Well, it depends on what role Shaokun Zhang had in the creation of the patch: if
    > he co-authored the patch and you finished it then you can add him as:
    >
    > Originally-from: Shaokun Zhang <zhangshaokun@hisilicon.com>
    >
    > or if he tested/reviewed the patch then his entry should be Reviewed-by/Acked-by
    > or Tested-by.
    >

    Hi Ingo, Arnaldo,

    I think it would be fair to say the former, that is: "he co-authored the
    patch and you finished it".

    Thanks,
    John

    > Thanks,
    >
    > Ingo
    >
    > _______________________________________________
    > linux-arm-kernel mailing list
    > linux-arm-kernel@lists.infradead.org
    > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
    >
    >


    \
     
     \ /
      Last update: 2018-03-13 16:28    [W:3.347 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site