Messages in this thread | | | Date | Mon, 12 Mar 2018 11:26:14 -0400 | From | Richard Guy Briggs <> | Subject | Re: [PATCH ghak21 V2 3/4] audit: add refused symlink to audit_names |
| |
On 2018-03-12 11:12, Paul Moore wrote: > On Mon, Mar 12, 2018 at 2:31 AM, Richard Guy Briggs <rgb@redhat.com> wrote: > > Audit link denied events for symlinks had duplicate PATH records rather > > than just updating the existing PATH record. Update the symlink's PATH > > record with the current dentry and inode information. > > > > See: https://github.com/linux-audit/audit-kernel/issues/21 > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com> > > --- > > fs/namei.c | 1 + > > 1 file changed, 1 insertion(+) > > Why didn't you include this in patch 4/4 like I asked during the > previous review?
Please see the last comment of: https://www.redhat.com/archives/linux-audit/2018-March/msg00070.html
> > diff --git a/fs/namei.c b/fs/namei.c > > index 50d2533..00f5041 100644 > > --- a/fs/namei.c > > +++ b/fs/namei.c > > @@ -945,6 +945,7 @@ static inline int may_follow_link(struct nameidata *nd) > > if (nd->flags & LOOKUP_RCU) > > return -ECHILD; > > > > + audit_inode(nd->name, nd->stack[0].link.dentry, 0); > > audit_log_link_denied("follow_link", &nd->stack[0].link); > > return -EACCES; > > } > > paul moore
- RGB
-- Richard Guy Briggs <rgb@redhat.com> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635
| |