Messages in this thread | | | From | Richard Weinberger <> | Subject | Re: [PATCH 0/2] mtd: use put_device() if device_register fail | Date | Mon, 12 Mar 2018 15:32:29 +0100 |
| |
Arvind,
Am Montag, 12. März 2018, 06:51:24 CET schrieb Arvind Yadav: > On Monday 12 March 2018 01:05 AM, Richard Weinberger wrote: > > Am Freitag, 9. März 2018, 11:50:47 CET schrieb Arvind Yadav: > >> if device_register() returned an error! Always use put_device() > >> to give up the reference initialized. > >> > >> Arvind Yadav (2): > >> [PATCH 1/2] mtd: use put_device() if device_register fail > >> [PATCH 2/2] mtd: ubi: use put_device() if device_register fail > > > > Uhh, this is not obvious. Does device_register() really always return with > > a reference held in all (error) cases? > > > > Thanks, > > //richard > > if device_register() returned an error! Always use put_device() > to give up the reference initialized.(-- Please see the comment > for device_register() ). put_device() is able to handle those case > where it'll not return a reference.
You are right.
For both patches: Acked-by: Richard Weinberger <richard@nod.at>
Thanks, //richard
| |