Messages in this thread Patch in this message | | | From | Jiri Olsa <> | Subject | [PATCH 6/8] perf/core: Move perf_event_attr::sample_max_stack into perf_copy_attr | Date | Mon, 12 Mar 2018 14:45:46 +0100 |
| |
Moving sample_max_stack check and setup into perf_copy_attr, so we have all perf_event_attr initial setup in one place and can easily compare attrs in the new ioctl introduced in following change.
Suggested-by: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- kernel/events/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c index 57898102847f..bd61b4d68a25 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -9834,6 +9834,9 @@ static int perf_copy_attr(struct perf_event_attr __user *uattr, ret = -EINVAL; } + if (!attr->sample_max_stack) + attr->sample_max_stack = sysctl_perf_event_max_stack; + if (attr->sample_type & PERF_SAMPLE_REGS_INTR) ret = perf_reg_validate(attr->sample_regs_intr); out: @@ -10047,9 +10050,6 @@ SYSCALL_DEFINE5(perf_event_open, perf_paranoid_kernel() && !capable(CAP_SYS_ADMIN)) return -EACCES; - if (!attr.sample_max_stack) - attr.sample_max_stack = sysctl_perf_event_max_stack; - /* * In cgroup mode, the pid argument is used to pass the fd * opened to the cgroup directory in cgroupfs. The cpu argument -- 2.13.6
| |