Messages in this thread | | | Subject | Re: [2/3] mwifiex: support sysfs initiated device coredump | From | Arend van Spriel <> | Date | Mon, 12 Mar 2018 13:44:06 +0100 |
| |
On 3/12/2018 10:41 AM, Kalle Valo wrote: > Arend Van Spriel <arend.vanspriel@broadcom.com> wrote: > >> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops") >> it is possible to initiate a device coredump from user-space. This >> patch adds support for it adding the .coredump() driver callback. >> As there is no longer a need to initiate it through debugfs remove >> that code. >> >> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> > > Based on the discussion I assume this is ok to take to w-d-next. If that's not > the case, please let me know ASAP.
It is up to the mwifiex maintainers to decide, I guess. The ABI documentation need to be revised and change the callback to void return type. I am not sure what the best approach is. 1) apply this and fix return type later, or 2) fix return type and resubmit this. What is your opinion?
Regards, Arend
| |