lkml.org 
[lkml]   [2018]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v9] mmc: Export host capabilities to debugfs.
Date


> -----Original Message-----
> From: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com]
> Sent: Monday, March 12, 2018 12:08 PM
> To: Harish Jenny K N <harish_kandiga@mentor.com>; ulf.hansson@linaro.org;
> linus.walleij@linaro.org; adrian.hunter@intel.com; shawn.lin@rock-
> chips.com; Avri Altman <Avri.Altman@wdc.com>
> Cc: linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org;
> Vladimir_Zapolskiy@mentor.com
> Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs.
>
> On Mon, 2018-03-12 at 10:01 +0530, Harish Jenny K N wrote:
> > This patch exports the host capabilities to debugfs
> >
> > This idea of sharing host capabilities over debugfs came up from Abbas
> > Raza <Abbas_Raza@mentor.com> Earlier discussions:
> > https://lkml.org/lkml/2018/3/5/357
> > https://www.spinics.net/lists/linux-mmc/msg48219.html
> >
>
> Address below minors and, FWIW, take mine
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> > + for_each_set_bit(bit, (const unsigned long *)&caps,
> > BITS_PER_LONG)
>
> > + for_each_set_bit(bit, (const unsigned long *)&caps2,
> > BITS_PER_LONG)
>
> Explicit casting is not needed anymore in both cases.
Also maybe use sizeof(mmc_host_capabilities) instead of BITS_PER_LONG?


>
> --
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy
\
 
 \ /
  Last update: 2018-03-12 11:46    [W:0.062 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site