lkml.org 
[lkml]   [2018]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] perf/x86/intel: Add Tremont CPU PMU support

* kan.liang@linux.intel.com <kan.liang@linux.intel.com> wrote:

> + /*TODO: test Adaptive PEBS, no extra implementation needed */
> + /*TODO: test PDIR fixed counter */
> + /* TODO: OFFCORE_RESPONSE mask updates for 10nm convered IDI */
> + /*TODO: implement topdown metrics, base metrics interface same as SNC */

Do you ever _read_ the comments you are writing?

NAK for this kind of inconsistent mess, and it's a repeat pattern - you really
need to submit cleaner patches!

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-03-12 09:50    [W:0.044 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site