Messages in this thread | | | Date | Mon, 12 Mar 2018 09:49:06 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/4] perf/x86/intel: Add Tremont CPU PMU support |
| |
* kan.liang@linux.intel.com <kan.liang@linux.intel.com> wrote:
> + /*TODO: test Adaptive PEBS, no extra implementation needed */ > + /*TODO: test PDIR fixed counter */ > + /* TODO: OFFCORE_RESPONSE mask updates for 10nm convered IDI */ > + /*TODO: implement topdown metrics, base metrics interface same as SNC */
Do you ever _read_ the comments you are writing?
NAK for this kind of inconsistent mess, and it's a repeat pattern - you really need to submit cleaner patches!
Thanks,
Ingo
| |