lkml.org 
[lkml]   [2018]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 63/76] x86/retpoline: Avoid retpolines for built-in __init functions
    3.16.56-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Woodhouse <dwmw@amazon.co.uk>

    commit 66f793099a636862a71c59d4a6ba91387b155e0c upstream.

    There's no point in building init code with retpolines, since it runs before
    any potentially hostile userspace does. And before the retpoline is actually
    ALTERNATIVEd into place, for much of it.

    Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: karahmed@amazon.de
    Cc: peterz@infradead.org
    Cc: bp@alien8.de
    Link: https://lkml.kernel.org/r/1517484441-1420-2-git-send-email-dwmw@amazon.co.uk
    [bwh: Backported to 3.16: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    include/linux/init.h | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    --- a/include/linux/init.h
    +++ b/include/linux/init.h
    @@ -4,6 +4,13 @@
    #include <linux/compiler.h>
    #include <linux/types.h>

    +/* Built-in __init functions needn't be compiled with retpoline */
    +#if defined(RETPOLINE) && !defined(MODULE)
    +#define __noretpoline __attribute__((indirect_branch("keep")))
    +#else
    +#define __noretpoline
    +#endif
    +
    /* These macros are used to mark some functions or
    * initialized data (doesn't apply to uninitialized data)
    * as `initialization' functions. The kernel can take this
    @@ -39,7 +46,7 @@

    /* These are for everybody (although not all archs will actually
    discard it in modules) */
    -#define __init __section(.init.text) __cold notrace
    +#define __init __section(.init.text) __cold notrace __noretpoline
    #define __initdata __section(.init.data)
    #define __initconst __constsection(.init.rodata)
    #define __exitdata __section(.exit.data)
    \
     
     \ /
      Last update: 2018-03-12 04:13    [W:4.301 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site