Messages in this thread | | | From | Logan Gunthorpe <> | Date | Thu, 1 Mar 2018 17:15:51 -0700 | Subject | Re: [PATCH v2 02/10] PCI/P2PDMA: Add sysfs group to display p2pmem stats |
| |
On 01/03/18 10:44 AM, Bjorn Helgaas wrote: > I think these two statements are out of order, since the attributes > dereference pdev->p2pdma. And it looks like you set "error" > unnecessarily, since you return immediately looking at it.
Per the previous series, sysfs_create_group is must_check for some reason. I had a printk there but you didn't think it was necessary. So assigning it to error is the only way to squash the warning.
Logan
| |