Messages in this thread | | | Date | Fri, 9 Feb 2018 18:15:31 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] printk: move dump stack related code to lib/dump_stack.c |
| |
On (02/09/18 17:00), Dave Young wrote: [..] > > > > I'm hesitating to add #ifdef CONFIG_PRINTK in lib/dump_stack.c.
Agreed.
> Maybe conditionally build dump_stack.o only when CONFIG_PRINTK is true, > but not sure if there are some historic reason this is not done before, > will do some testing see if it works. >
Thanks.
Was thinking about the same thing - dump_stack() without CONFIG_PRINTK doesn't make that much sense anyway. Well, maybe it does in some weird case... Need to check. But it seems that we probably can just make the dependency, which already exists, explicit.
-ss
| |