lkml.org 
[lkml]   [2018]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [tip:x86/pti] x86/pti: Make sure the user/kernel PTEs match
From
Date
On 01/03/2018 08:22 AM, tip-bot for Thomas Gleixner wrote:
> --- a/arch/x86/mm/pti.c
> +++ b/arch/x86/mm/pti.c
> @@ -367,7 +367,8 @@ static void __init pti_setup_espfix64(void)
> static void __init pti_clone_entry_text(void)
> {
> pti_clone_pmds((unsigned long) __entry_text_start,
> - (unsigned long) __irqentry_text_end, _PAGE_RW);
> + (unsigned long) __irqentry_text_end,
> + _PAGE_RW | _PAGE_GLOBAL);
> }

We appear to have lost all of our global bits between this and the
cpu_entry_area itself. To make K8 happy, shouldn't we just *set*
_PAGE_GLOBAL universally instead of clearing it universally?

Also, don't we want _PAGE_GLOBAL in the cpu_entry_area.c pte setting? I
think I had this for all the shared user/kernel areas near the end of
the KAISER era, but we appear to have totally nuked it for PTI.

\
 
 \ /
  Last update: 2018-02-10 00:30    [W:0.112 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site