lkml.org 
[lkml]   [2018]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 3/3] mtd: nand: vf610: check mtd_device_register() return code
    Date
    vf610_nfc_probe() misses error handling of mtd_device_register().

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
    ---
    drivers/mtd/nand/vf610_nfc.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
    index 9cc5992e88c8..64fed3d9e3d4 100644
    --- a/drivers/mtd/nand/vf610_nfc.c
    +++ b/drivers/mtd/nand/vf610_nfc.c
    @@ -782,8 +782,13 @@ static int vf610_nfc_probe(struct platform_device *pdev)
    platform_set_drvdata(pdev, mtd);

    /* Register device in MTD */
    - return mtd_device_register(mtd, NULL, 0);
    + err = mtd_device_register(mtd, NULL, 0);
    + if (err)
    + goto err_cleanup_nand;
    + return 0;

    +err_cleanup_nand:
    + nand_cleanup(chip);
    err_disable_clk:
    clk_disable_unprepare(nfc->clk);
    return err;
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-02-09 23:30    [W:3.171 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site