lkml.org 
[lkml]   [2018]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf report: Fix wrong jump arrow
Em Mon, Jan 29, 2018 at 06:57:53PM +0800, Jin Yao escreveu:
> When we use perf report interactive annotate view, we can see
> the position of jump arrow is not correct. For example,
>
> 1. perf record -b ...
> 2. perf report
> 3. In interactive mode, select Annotate 'function'
>
> Percent│ IPC Cycle
> │ if (flag)
> 1.37 │0.4┌── 1 ↓ je 82
> │ │ x += x / y + y / x;

Applied and added this to the cset log, please check:

Committer notes:

Please note that only from LBRv5 (according to Jiri) onwards, i.e. >=
Skylake is that we'll have the cycles counts in each branch record
entry, so to see the Cycles and IPC columns, and be able to test this
patch, one need a capable hardware.

While applying this I first tested it on a Broadwell class machine and
couldn't get those columns, will add code to the annotate browser to
warn the user about that, i.e. you have branch records, but no cycles,
use a more recent hardware to get the cycles and IPC columns.

- Arnaldo

\
 
 \ /
  Last update: 2018-02-09 16:16    [W:0.053 / U:1.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site