lkml.org 
[lkml]   [2018]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] zsmalloc: introduce zs_huge_object() function
On (02/08/18 20:10), Matthew Wilcox wrote:
> > > > +/*
> > > > + * Check if the object's size falls into huge_class area. We must take
> > > > + * ZS_HANDLE_SIZE into account and test the actual size we are going to
> > > > + * use up. zs_malloc() unconditionally adds handle size before it performs
> > > > + * size_class lookup, so we may endup in a huge class yet zs_huge_object()
> > > > + * returned 'false'.
> > > > + */
> > >
> > > Can you please reformat this comment as kernel-doc?
> >
> > Is this - Documentation/doc-guide/kernel-doc.rst - the right thing
> > to use as a reference?
>
> Yes. I just sent a revision to it that makes it (I think) a little
> easier to read. Try this version:

That's helpful, thanks! Will take a look and re-spin the patch.

-ss

\
 
 \ /
  Last update: 2018-02-09 06:05    [W:0.060 / U:1.456 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site