lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ftrace: fix the file mode of graph tracer and stacktracer
On Fri, 9 Feb 2018 10:33:31 +0800
"Zhengyuan Liu" <liuzhengyuan@kylinos.cn> wrote:

> It doesn't affect root writing to those files as root is a super user and
> can access to any write-only files. I just want to make those writable

Ah, I know when I vim a file that's read only, even for root vim will
complain. But there's no complaining with redirection.

I just tried vim on set_graph_function, and yeah, it does complain.

> file to look consistent with others, seeing bellow:
>
> -rw-r--r-- 1 root root set_event_pid
> -rw-r--r-- 1 root root set_ftrace_filter
> -rw-r--r-- 1 root root set_ftrace_notrace
> -rw-r--r-- 1 root root set_ftrace_pid
> -r--r--r-- 1 root root set_graph_function
> -r--r--r-- 1 root root set_graph_notrace

Yeah, I understand.

>
> If this patch makes no sense, just ignore it!

No no, it makes perfect sense. I plan on adding it. But it's not that
important to be included for stable. Expect to see this in 4.17.

Thanks!

-- Steve

\
 
 \ /
  Last update: 2018-02-09 04:22    [W:0.038 / U:5.656 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site