lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally
From
Date
Hi,

Anybody else here who can give an attention on this review?

Thanks,
Jia

On 2018/2/5 下午5:26, Jiri Olsa wrote:
> On Tue, Jan 30, 2018 at 02:42:59PM +0800, Jia Zhang wrote:
>> The vsyscall page should be visible only if
>> vsyscall=emulate/native when dumping /proc/kcore.
>>
>> Signed-off-by: Jia Zhang <zhang.jia@linux.alibaba.com>
>> ---
>> arch/x86/mm/init_64.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index dab78f6..3d4cf33 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1186,8 +1186,9 @@ void __init mem_init(void)
>> register_page_bootmem_info();
>>
>> /* Register memory areas for /proc/kcore */
>> - kclist_add(&kcore_vsyscall, (void *)VSYSCALL_ADDR,
>> - PAGE_SIZE, KCORE_USER);
>> + if (get_gate_vma(&init_mm))
>> + kclist_add(&kcore_vsyscall, (void *)VSYSCALL_ADDR,
>> + PAGE_SIZE, KCORE_USER);
>
> nit, we use { } when there's more than 1 line code
>
> anyway the approach looks ok to me
>
> Reviewed-by: Jiri Olsa <jolsa@kernel.org>
>
> thanks,
> jirka
>

\
 
 \ /
  Last update: 2018-02-09 02:08    [W:0.033 / U:3.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site