lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/10] perf tools: Use machine__set_kernel_mmap instead of map_groups__fixup_end
On Thu, Feb 08, 2018 at 09:34:18AM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> On Wed, Feb 07, 2018 at 03:48:34PM +0100, Jiri Olsa wrote:
> > The machine__set_kernel_mmap does the same job as map_groups__fixup_end
> > when used on kernel maps within machine__create_kernel_maps call.
>
> I'm not sure. Modules have end address after machine__create_module()
> but vmlinux_maps is not. So map_groups__fixup() will set the end of
> vmlinux_maps but with this change it will have ~0ULL.

ugh, I missed the machine__create_modules call in there,
I'll rework and repost the patchset

thanks,
jirka

\
 
 \ /
  Last update: 2018-02-08 09:57    [W:0.033 / U:1.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site