lkml.org 
[lkml]   [2018]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: Extra '_get' in declaration of arch_get_platform_mac_address
From
From: Mathieu Malaterre <malat@debian.org>
Date: Wed, 7 Feb 2018 20:35:00 +0100

> In commit c7f5d105495a ("net: Add eth_platform_get_mac_address() helper."),
> two declarations were added:
>
> int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr);
> unsigned char *arch_get_platform_get_mac_address(void);
>
> An extra '_get' was introduced in arch_get_platform_get_mac_address, remove
> it. Fix compile warning using W=1:
>
> CC net/ethernet/eth.o
> net/ethernet/eth.c:523:24: warning: no previous prototype for ‘arch_get_platform_mac_address’ [-Wmissing-prototypes]
> unsigned char * __weak arch_get_platform_mac_address(void)
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> AR net/ethernet/built-in.o
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

I'm very surprised this warning didn't get triggered before.

That's really weird!

Applied, thank you.
\
 
 \ /
  Last update: 2018-02-08 21:14    [W:0.032 / U:4.916 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site