| From | James Hogan <> | Date | Thu, 8 Feb 2018 17:35:30 +0000 | Subject | Re: [PATCH 16/20] auxdisplay: img-ascii-lcd: Remove MIPS_SEAD3 dep. |
| |
On 5 February 2018 at 01:21, Ulf Magnusson <ulfalizer@gmail.com> wrote: > The MIPS_SEAD3 symbol was removed in commit 64601cb1343f ("leds: Remove SEAD-3 > driver"). > > Remove the MIPS_SEAD3 dependency from IMG_ASCII_LCD.
Its not a dependency, just a default (presumably so that existing kernel configs get updated automatically).
Note that sead3 now uses MIPS_GENERIC (or more specifically CONFIG_LEGACY_BOARD_SEAD3), but this driver is enabled in the config snippets, e.g.: arch/mips/configs/generic/board-sead-3.config arch/mips/configs/generic/board-boston.config
so indeed there is no real need to replace MIPS_SEAD3 with anything here.
Cheers James
> > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- > drivers/auxdisplay/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index 2c2ed9cf8796..3cba78d36eec 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -137,7 +137,7 @@ config CFAG12864B_RATE > config IMG_ASCII_LCD > tristate "Imagination Technologies ASCII LCD Display" > depends on HAS_IOMEM > - default y if MIPS_MALTA || MIPS_SEAD3 > + default y if MIPS_MALTA > select SYSCON > help > Enable this to support the simple ASCII LCD displays found on > -- > 2.14.1 >
-- James Hogan
|