lkml.org 
[lkml]   [2018]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 1/1] ext4/f2fs: don't put symlink in pagecache into highmem
Some minor nits for when you send your next patch for stable:

On Tue, Feb 06, 2018 at 03:53:53PM -0800, Jin Qian wrote:
> From: Jin Qian <jinqian@google.com>

The original patch was written by Al Viro, please do not take the
original authorship off, that's not good.

> partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream
> to v4.4 to prevent virt_to_page on highmem.
>
> ext4_encrypted_follow_link uses kmap() for cpage
> caddr = kmap(cpage);
>
> _ext4_fname_disk_to_usr calls virt_to_page on the kmapped address.
> _ext4_fname_disk_to_usr()
> ext4_fname_decrypt()
> sg_init_one()
> sg_init_one(&src_sg, iname->name, iname->len);
> sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));
>
> Cc: linux-stable <stable@vger.kernel.org> # 4.4.y
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Jin Qian <jinqian@google.com>
> Signed-off-by: Jin Qian <jinqian@android.com>

Why did you sign off on this twice?

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-02-07 22:19    [W:0.024 / U:9.648 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site