Messages in this thread | | | Subject | Re: [PATCH] bluetooth: hci_ath: Replace mdelay with msleep in ath_wakeup_ar3k | From | Marcel Holtmann <> | Date | Wed, 7 Feb 2018 09:55:48 +0100 |
| |
Hi Jia-Ju,
> ath_wakeup_ar3k() is never called from atomic context. > > It is only called by ath_hci_uart_work() that is only called in > ath_open() via INIT_WORK(). > All of the above functions do not enter atomic context along the way. > > Despite never getting called from atomic context, ath_wakeup_ar3k() calls > mdelay() for busy wait. > That is not necessary and can be replaced with msleep to avoid busy wait. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- > drivers/bluetooth/hci_ath.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
| |