lkml.org 
[lkml]   [2018]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] bluetooth: hci_ath: Replace mdelay with msleep in ath_wakeup_ar3k
From
Date
Hi Jia-Ju,

> ath_wakeup_ar3k() is never called from atomic context.
>
> It is only called by ath_hci_uart_work() that is only called in
> ath_open() via INIT_WORK().
> All of the above functions do not enter atomic context along the way.
>
> Despite never getting called from atomic context, ath_wakeup_ar3k() calls
> mdelay() for busy wait.
> That is not necessary and can be replaced with msleep to avoid busy wait.
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
> drivers/bluetooth/hci_ath.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

\
 
 \ /
  Last update: 2018-02-07 09:57    [W:0.028 / U:7.988 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site