lkml.org 
[lkml]   [2018]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] bluetooth: btmrvl_main: Replace GFP_ATOMIC with GFP_KERNEL in btmrvl_send_sync_cmd
From
Date
Hi Jia-Ju,

> After checking all possible call chains to btmrvl_send_sync_cmd(),
> my tool finds that this function is never called in atomic context,
> namely never in an interrupt handler or holding a spinlock.
> And it calls wait_event_interruptible_timeout() after bt_skb_alloc(),
> so it indicates that btmrvl_send_sync_cmd()
> can call function which can sleep.
> Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL.
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
> drivers/bluetooth/btmrvl_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

\
 
 \ /
  Last update: 2018-02-07 09:56    [W:0.030 / U:14.792 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site