lkml.org 
[lkml]   [2018]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] trace-cmd: Fix the detection for swig
On Wed, 7 Feb 2018 22:01:46 +0800
Zamir SUN <sztsian@gmail.com> wrote:


> Thanks for the heads-up! I did not see that before.
>
> While just a note for this, in Fedora 27:
>
> $ if command -v swig; then echo 1; else echo 0; fi
> /usr/bin/swig
> 1
>
> Actually this test has the same problem as of `which swig` - When swig
> exists, the var SWIG_DEFINED will not be 1 (as shown above).
>
> I see Vladislav is already on this thread. I hope this can be fixed
> before merging the patch set.
>

After doing some more testing, I'm going to push out the changes today.
Would you be able to add patches on top of the changes? We are doing a
restructuring of the directory such that it can grow more.

I'll be backporting these fixes to 2.6 and 2.7 as well.

Thanks!

-- Steve

\
 
 \ /
  Last update: 2018-02-07 15:41    [W:0.064 / U:5.208 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site