Messages in this thread | | | Subject | Re: [PATCH] crypto: s5p-sss.c: Fix kernel Oops in AES-ECB mode | From | Kamil Konieczny <> | Date | Tue, 06 Feb 2018 18:10:55 +0100 |
| |
On 06.02.2018 17:48, Anand Moon wrote: > Hi Kamil, > > Thanks for providing the fix to this issue. > > On 5 February 2018 at 23:10, Kamil Konieczny > <k.konieczny@partner.samsung.com> wrote: >> >> In AES-ECB mode crypt is done with key only, so any use of IV >> can cause kernel Oops, as reported by Anand Moon. > > If possible could you avoid the name in commit message.
This is added after '---' line, so it will not appear in commit message.
>> Fixed it by using IV only in AES-CBC and AES-CTR. >> >> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> >> Reported-by: Anand Moon <linux.amoon@gmail.com> > > [snip] > > Please add my. Tested on Odroid HC2 > > Tested-by: Anand Moon <linux.amoon@gmail.com>
This will add you name in commit message, additionally with 'Reported-by:' line.
> Below are the result at my end. > > aes-cbc-essiv:sha256 (128 bit key) > WRITE: > 100+0 records in > 100+0 records out > 838860800 bytes (839 MB, 800 MiB) copied, 11.7225 s, 71.6 MB/s > [...]
is it from 'cryptsetup benchmark' ? benchmark did not cause oops. Please test with luksFormat, ie. use
cryptsetup luksFormat --debug -q -d /tmp/testkey.key \ --cipher aes-cbc-essiv:sha256 -h sha256 -s 128 /tmp/test.bin
-- Best regards, Kamil Konieczny Samsung R&D Institute Poland
| |