lkml.org 
[lkml]   [2018]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/3] HID: lenovo: Improve a size determination in lenovo_probe_tpkbd()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 6 Feb 2018 16:52:58 +0100

    Replace the specification of a data structure by a pointer dereference
    as the parameter for the operator "sizeof" to make the corresponding size
    determination a bit safer according to the Linux coding style convention.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/hid/hid-lenovo.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
    index 549b84d01b46..f863b94f3476 100644
    --- a/drivers/hid/hid-lenovo.c
    +++ b/drivers/hid/hid-lenovo.c
    @@ -685,7 +685,7 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev)
    hid_warn(hdev, "Could not create sysfs group: %d\n", ret);

    data_pointer = devm_kzalloc(&hdev->dev,
    - sizeof(struct lenovo_drvdata_tpkbd),
    + sizeof(*data_pointer),
    GFP_KERNEL);
    if (data_pointer == NULL) {
    ret = -ENOMEM;
    --
    2.16.1
    \
     
     \ /
      Last update: 2018-02-06 17:18    [W:2.437 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site