Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 5 Feb 2018 09:36:35 -0800 | Subject | Re: [RFC][PATCH] <linux/stringhash.h>: fix end_name_hash() for 64bit long |
| |
On Mon, Feb 5, 2018 at 9:32 AM, Amir Goldstein <amir73il@gmail.com> wrote: > > Assuming the fix is not moronic, I wouldn't even know where to begin testing > its affects, or how to prove if there really is a problem. > Any suggestions?
So I *think* that this was on purpose, but it's a long time ago, and we've changed some of the hashing since.
And I think you're wrong that it's a no-op on 32-bit. It's a very expensive and pointless multiplication there too, even if the *shift* ends up being a nop-op.
The name hashing is pretty performance-sensitive.
Linus
| |