Messages in this thread | | | Date | Mon, 5 Feb 2018 16:11:22 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: phy-micrel: remove redundant initialization of pointer of_node |
| |
On Mon, Feb 05, 2018 at 12:47:59PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Pointer of_node is initialized with a value that is never read, of_node > is later updated with a new value instead, hence the initialization is > redundant and can be removed. Also remove unused pointer dev and > remove an empty line. > > Cleans up clang warnings: > drivers/net/phy/micrel.c:393:28: warning: Value stored to 'of_node' > during its initialization is never read > drivers/net/phy/micrel.c:532:28: warning: Value stored to 'of_node' > during its initialization is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Hi Colin
You probably need to repost once netdev re-opens.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |