lkml.org 
[lkml]   [2018]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.14 056/110] crypto: inside-secure - free requests even if their handling failed
    Date
    From: Antoine Ténart <antoine.tenart@free-electrons.com>

    [ Upstream commit 0a02dcca126280595950f3ea809f77c9cb0a235c ]

    This patch frees the request private data even if its handling failed,
    as it would never be freed otherwise.

    Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
    Suggested-by: Ofer Heifetz <oferh@marvell.com>
    Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/crypto/inside-secure/safexcel.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
    index 89ba9e85c0f3..4bcef78a08aa 100644
    --- a/drivers/crypto/inside-secure/safexcel.c
    +++ b/drivers/crypto/inside-secure/safexcel.c
    @@ -607,6 +607,7 @@ static inline void safexcel_handle_result_descriptor(struct safexcel_crypto_priv
    ndesc = ctx->handle_result(priv, ring, sreq->req,
    &should_complete, &ret);
    if (ndesc < 0) {
    + kfree(sreq);
    dev_err(priv->dev, "failed to handle result (%d)", ndesc);
    return;
    }
    --
    2.11.0
    \
     
     \ /
      Last update: 2018-02-03 19:37    [W:4.083 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site