lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 041/254] can: kvaser_usb: free buf in error paths
    3.16.55-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jimmy Assarsson <jimmyassarsson@gmail.com>

    commit 435019b48033138581a6171093b181fc6b4d3d30 upstream.

    The allocated buffer was not freed if usb_submit_urb() failed.

    Signed-off-by: Jimmy Assarsson <jimmyassarsson@gmail.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/can/usb/kvaser_usb.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/can/usb/kvaser_usb.c
    +++ b/drivers/net/can/usb/kvaser_usb.c
    @@ -608,6 +608,7 @@ static int kvaser_usb_simple_msg_async(s
    if (err) {
    netdev_err(netdev, "Error transmitting URB\n");
    usb_unanchor_urb(urb);
    + kfree(buf);
    usb_free_urb(urb);
    return err;
    }
    @@ -1406,6 +1407,7 @@ static netdev_tx_t kvaser_usb_start_xmit
    spin_unlock_irqrestore(&priv->tx_contexts_lock, flags);

    usb_unanchor_urb(urb);
    + kfree(buf);

    stats->tx_dropped++;

    \
     
     \ /
      Last update: 2018-02-28 18:15    [W:4.032 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site