lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 199/254] powerpc: Don't preempt_disable() in show_cpuinfo()
    3.16.55-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

    commit 349524bc0da698ec77f2057cf4a4948eb6349265 upstream.

    This causes warnings from cpufreq mutex code. This is also rather
    unnecessary and ineffective. If we really want to prevent concurrent
    unplug, we could take the unplug read lock but I don't see this being
    critical.

    Fixes: cd77b5ce208c ("powerpc/powernv/cpufreq: Fix the frequency read by /proc/cpuinfo")
    Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/powerpc/kernel/setup-common.c | 11 -----------
    1 file changed, 11 deletions(-)

    --- a/arch/powerpc/kernel/setup-common.c
    +++ b/arch/powerpc/kernel/setup-common.c
    @@ -216,14 +216,6 @@ static int show_cpuinfo(struct seq_file
    unsigned short maj;
    unsigned short min;

    - /* We only show online cpus: disable preempt (overzealous, I
    - * knew) to prevent cpu going down. */
    - preempt_disable();
    - if (!cpu_online(cpu_id)) {
    - preempt_enable();
    - return 0;
    - }
    -
    #ifdef CONFIG_SMP
    pvr = per_cpu(cpu_pvr, cpu_id);
    #else
    @@ -328,9 +320,6 @@ static int show_cpuinfo(struct seq_file
    #ifdef CONFIG_SMP
    seq_printf(m, "\n");
    #endif
    -
    - preempt_enable();
    -
    /* If this is the last cpu, print the summary */
    if (cpumask_next(cpu_id, cpu_online_mask) >= nr_cpu_ids)
    show_cpuinfo_summary(m);
    \
     
     \ /
      Last update: 2018-02-28 17:54    [W:4.087 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site