lkml.org 
[lkml]   [2018]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 164/254] usbip: remove kernel addresses from usb device and urb debug msgs
    3.16.55-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Shuah Khan <shuahkh@osg.samsung.com>

    commit e1346fd87c71a1f61de1fe476ec8df1425ac931c upstream.

    usbip_dump_usb_device() and usbip_dump_urb() print kernel addresses.
    Remove kernel addresses from usb device and urb debug msgs and improve
    the message content.

    Instead of printing parent device and bus addresses, print parent device
    and bus names.

    Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    [bwh: Backported to 3.16: adjust filename]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/staging/usbip/usbip_common.c | 17 +++--------------
    1 file changed, 3 insertions(+), 14 deletions(-)

    --- a/drivers/staging/usbip/usbip_common.c
    +++ b/drivers/staging/usbip/usbip_common.c
    @@ -103,7 +103,7 @@ static void usbip_dump_usb_device(struct
    dev_dbg(dev, " devnum(%d) devpath(%s) usb speed(%s)",
    udev->devnum, udev->devpath, usb_speed_string(udev->speed));

    - pr_debug("tt %p, ttport %d\n", udev->tt, udev->ttport);
    + pr_debug("tt hub ttport %d\n", udev->ttport);

    dev_dbg(dev, " ");
    for (i = 0; i < 16; i++)
    @@ -136,12 +136,8 @@ static void usbip_dump_usb_device(struct
    }
    pr_debug("\n");

    - dev_dbg(dev, "parent %p, bus %p\n", udev->parent, udev->bus);
    -
    - dev_dbg(dev,
    - "descriptor %p, config %p, actconfig %p, rawdescriptors %p\n",
    - &udev->descriptor, udev->config,
    - udev->actconfig, udev->rawdescriptors);
    + dev_dbg(dev, "parent %s, bus %s\n", dev_name(&udev->parent->dev),
    + udev->bus->bus_name);

    dev_dbg(dev, "have_langid %d, string_langid %d\n",
    udev->have_langid, udev->string_langid);
    @@ -249,9 +245,6 @@ void usbip_dump_urb(struct urb *urb)

    dev = &urb->dev->dev;

    - dev_dbg(dev, " urb :%p\n", urb);
    - dev_dbg(dev, " dev :%p\n", urb->dev);
    -
    usbip_dump_usb_device(urb->dev);

    dev_dbg(dev, " pipe :%08x ", urb->pipe);
    @@ -260,11 +253,9 @@ void usbip_dump_urb(struct urb *urb)

    dev_dbg(dev, " status :%d\n", urb->status);
    dev_dbg(dev, " transfer_flags :%08X\n", urb->transfer_flags);
    - dev_dbg(dev, " transfer_buffer :%p\n", urb->transfer_buffer);
    dev_dbg(dev, " transfer_buffer_length:%d\n",
    urb->transfer_buffer_length);
    dev_dbg(dev, " actual_length :%d\n", urb->actual_length);
    - dev_dbg(dev, " setup_packet :%p\n", urb->setup_packet);

    if (urb->setup_packet && usb_pipetype(urb->pipe) == PIPE_CONTROL)
    usbip_dump_usb_ctrlrequest(
    @@ -274,8 +265,6 @@ void usbip_dump_urb(struct urb *urb)
    dev_dbg(dev, " number_of_packets :%d\n", urb->number_of_packets);
    dev_dbg(dev, " interval :%d\n", urb->interval);
    dev_dbg(dev, " error_count :%d\n", urb->error_count);
    - dev_dbg(dev, " context :%p\n", urb->context);
    - dev_dbg(dev, " complete :%p\n", urb->complete);
    }
    EXPORT_SYMBOL_GPL(usbip_dump_urb);

    \
     
     \ /
      Last update: 2018-02-28 17:11    [W:4.038 / U:0.700 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site