Messages in this thread Patch in this message | | | From | Leo Yan <> | Subject | [PATCH RESEND v3] checkpatch: Fix checks for Kconfig help text | Date | Wed, 28 Feb 2018 13:03:10 +0800 |
| |
If one patch has Kconfig section, the check script variable '$is_start' will be set by first 'config' line and the variable '$is_end' is to be set by the second 'config' line. But patches often has only one 'config' line so we have no chance to set '$is_end', as result below condition is invalid and it skips check for Kconfig description:
if ($is_start && $is_end && $length < $min_conf_desc_length) { ...... }
When script runs to this condition sentence it means the Kconfig section parsing has been completed, whatever '$is_end' is true or not. So removes '$is_end' from condition sentence.
Signed-off-by: Leo Yan <leo.yan@linaro.org> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3d40403..5cbc887 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2828,7 +2828,7 @@ sub process { } $length++; } - if ($is_start && $is_end && $length < $min_conf_desc_length) { + if ($is_start && $length < $min_conf_desc_length) { WARN("CONFIG_DESCRIPTION", "please write a paragraph that describes the config symbol fully\n" . $herecurr); } -- 1.9.1
| |