lkml.org 
[lkml]   [2018]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] objtool: use global host flags for compilation
On Tue, Feb 27, 2018 at 09:55:23PM +0100, Robin Jarry wrote:
> 2018-02-27, Josh Poimboeuf:
> > On Mon, Feb 26, 2018 at 07:41:48PM +0100, Robin Jarry wrote:
> [snip]
> > > ifdef CONFIG_STACK_VALIDATION
> > > has_libelf := $(call try-run,\
> > > - echo "int main() {}" | $(HOSTCC) -xc -o /dev/null -lelf -,1,0)
> > > + echo "int main() {}" | $(HOSTCC) $(HOSTLDFLAGS) -xc -o /dev/null -lelf -,1,0)
> >
> > This should probably also have HOSTCFLAGS, since the objtool makefile
> > uses it as well.
>
> I had intentionally omitted HOSTCFLAGS since the compiled code does not
> contain any #include statements (only -lelf). But adding them cannot
> hurt.

Ah, right. The point of this check is to see if it can find libelf, so
I guess using HOSTCFLAGS wouldn't have a point here. So it's fine the
way it is.

--
Josh

\
 
 \ /
  Last update: 2018-02-27 22:42    [W:0.204 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site