Messages in this thread | | | Subject | Re: [PATCH] sparse doesn't support indirect_branch attribute | From | Randy Dunlap <> | Date | Tue, 27 Feb 2018 12:18:30 -0800 |
| |
On 02/27/2018 11:48 AM, Matthew Wilcox wrote: > > Don't use __attribute__((indirect_branch)) if we're compiling with > sparse. > > Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com> > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index e2c7f4369eff..b6be4cc25e9d 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -93,7 +93,7 @@ > #define __weak __attribute__((weak)) > #define __alias(symbol) __attribute__((alias(#symbol))) > > -#ifdef RETPOLINE > +#if defined(RETPOLINE) && !defined(__CHECKER__) > #define __noretpoline __attribute__((indirect_branch("keep"))) > #endif > >
I don't mind the patch, but I did send a patch for this attribute on Feb. 13, 2018, to the sparse mailing list.
-- ~Randy
| |