Messages in this thread | | | From | Fabio Estevam <> | Date | Mon, 26 Feb 2018 09:43:27 -0300 | Subject | Re: [PATCH] pinctrl: imx: fix unsigned check if nfuncs with less than or equal zero |
| |
On Mon, Feb 26, 2018 at 9:04 AM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The unsigned integer nfuncs is being error checked with a value less > or equal to zero; this is always false if of_get_child_count returns > a -ve for an error condition since nfuncs is not signed. Fix this by > making variables nfuncs and i signed integers. > > Detected with Coccinelle: > drivers/pinctrl/freescale/pinctrl-imx.c:620:6-12: WARNING: Unsigned > expression compared with zero: nfuncs <= 0 > > Fixes: ae75ff814538 ("pinctrl: pinctrl-imx: add imx pinctrl core driver") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
| |