Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Mon, 26 Feb 2018 17:43:01 +0800 | Subject | Re: [PATCH 01/15] clk: sunxi-ng: Add check for minimal rate to NM PLLs |
| |
On Mon, Feb 26, 2018 at 5:38 PM, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > Hi, > > On Sat, Feb 24, 2018 at 10:45:31PM +0100, Jernej Skrabec wrote: >> Some NM PLLs doesn't work well when their output clock rate is set below >> certain rate. >> >> Add support for that constrain. > > In such a case, you should round the rate to the minimum the clock can > operate at, and not return an error.
That's true for round_rate. But what's the expected behavior of set_rate? AFAIK we presume all users call round_rate before set_rate, but that doesn't seem to be true all the time.
ChenYu
| |