Messages in this thread | | | Subject | Re: [PATCH v3 2/2] x86/apic: Replace common tools with new ones | From | Dou Liyang <> | Date | Mon, 26 Feb 2018 08:51:45 +0800 |
| |
Hi Andy,
At 02/23/2018 08:40 PM, Andy Shevchenko wrote: > On Fri, Feb 23, 2018 at 9:54 AM, Dou Liyang <douly.fnst@cn.fujitsu.com> wrote: >> The pending interrupt check code is old, update the following code. >> >> -Replace for() with for_each_set_bit() > >> - for (j = 31; j >= 0; j--) { >> - if (value & (1<<j)) { >> + for_each_set_bit(j, &value, 32) { > > for_each_set_bit(), mind 'set' part, is equivalent to for-if pair... > >> + if (j) { > > ...here you just exclude bit 0 from consideration by unknown reason. >
Oops! my fault, will modify it.
Thanks, dou
>> ack_APIC_irq(); >> acked++; >> } >> } >
| |