lkml.org 
[lkml]   [2018]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] power: reset: Add Spreadtrum SC27xx PMIC power off support
Hi Baolin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on power-supply/for-next]
[also build test ERROR on v4.16-rc2 next-20180223]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Baolin-Wang/power-reset-Add-Spreadtrum-SC27xx-PMIC-power-off-support/20180224-195742
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh

All errors (new ones prefixed by >>):

drivers/power/reset/sc27xx-poweroff.c: In function 'sc27xx_poweroff_shutdown':
>> drivers/power/reset/sc27xx-poweroff.c:32:2: error: implicit declaration of function 'freeze_secondary_cpus' [-Werror=implicit-function-declaration]
freeze_secondary_cpus(cpu);
^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/freeze_secondary_cpus +32 drivers/power/reset/sc27xx-poweroff.c

18
19 /*
20 * On Spreadtrum platform, we need power off system through external SC27xx
21 * series PMICs, and it is one similar SPI bus mapped by regmap to access PMIC,
22 * which is not fast io access.
23 *
24 * So before stopping other cores, we need release other cores' resource by
25 * taking cpus down to avoid racing regmap or spi mutex lock when poweroff
26 * system through PMIC.
27 */
28 void sc27xx_poweroff_shutdown(void)
29 {
30 int cpu = smp_processor_id();
31
> 32 freeze_secondary_cpus(cpu);
33 }
34

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-02-24 13:38    [W:0.054 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site